Skip to content

REST API: Migrate order stats #8547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 5, 2023
Merged

REST API: Migrate order stats #8547

merged 4 commits into from
Jan 5, 2023
+102 −2

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Jan 4, 2023 •
edited
Loading

Closes #8544

Description

Testing instructions

This PR migrates the order stats endpoint to enable REST API. Changes include:

  • Updated OrderStatsV4Mapper to parse contents without the data envelope
  • Enabled REST API for the loadOrderStats request.

Screenshots

  • In DefaultFeatureFlagService, enable the flag for applicationPasswordAuthenticationForSiteCredentialLogin and build the app.
  • Log out of the app or skip onboarding if needed.
  • On the prologue screen, select "Enter your site address".
  • Enter your test store address and tap "Continue".
  • Enter the correct site credentials for your account in the test store.
  • After the login succeeds, you should be navigated to the home screen.
  • On the dashboard screen, notice that the order stats are loaded and displayed correctly.

Please feel free to test again by logging in with a WPCom account. The order stats for your store should still be correct.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: stats Related to stats, including Top Performers. status: feature-flagged Behind a feature flag. Milestone is not strongly held. labels Jan 4, 2023
@itsmeichigo itsmeichigo added this to the 11.8 milestone Jan 4, 2023
@peril-woocommerce
Copy link

peril-woocommerce bot commented Jan 4, 2023

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 4, 2023

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8547-7871073 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@jaclync jaclync self-assigned this Jan 5, 2023
jaclync
jaclync approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 - all the reports/revenue/stats requests were successful!

@itsmeichigo itsmeichigo mentioned this pull request Jan 5, 2023
Closed
2 tasks
Base automatically changed from feat/8544-migrate-leaderboard to trunk January 5, 2023 04:26
@itsmeichigo itsmeichigo merged commit 09a52be into trunk Jan 5, 2023
@itsmeichigo itsmeichigo deleted the feat/8544-migrate-order-stats branch January 5, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaclync jaclync jaclync approved these changes

@selanthiraiyan selanthiraiyan Awaiting requested review from selanthiraiyan

Assignees

@jaclync jaclync

Labels

feature: stats Related to stats, including Top Performers. status: feature-flagged Behind a feature flag. Milestone is not strongly held. type: task An internally driven task.

Projects

None yet

Milestone

11.8

Development

Successfully merging this pull request may close these issues.

REST API: Migrate stats on dashboard screen

4 participants

@itsmeichigo @wpmobilebot @jaclync